Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of rendering-lists #321

Merged

Conversation

vishnupprajapat
Copy link
Contributor

@vishnupprajapat vishnupprajapat commented Jan 7, 2025

New Hindi Translation Progress #168

@arshadkazmi42

Changes Proposed

Translation of rendering-lists

@vishnupprajapat
Copy link
Contributor Author

New Hindi Translation Progress #168
@arshadkazmi42

@arshadkazmi42
Copy link
Member

@vishnupprajapat Thank you for the PR. I will review it soon.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Overall looks good 👍

I have left a few minor comments, can you fix those? Once those are fixed we can merge the PR.

src/content/learn/rendering-lists.md Outdated Show resolved Hide resolved
src/content/learn/rendering-lists.md Outdated Show resolved Hide resolved
src/content/learn/rendering-lists.md Outdated Show resolved Hide resolved
src/content/learn/rendering-lists.md Outdated Show resolved Hide resolved
src/content/learn/rendering-lists.md Outdated Show resolved Hide resolved
src/content/learn/rendering-lists.md Outdated Show resolved Hide resolved
src/content/learn/rendering-lists.md Outdated Show resolved Hide resolved
src/content/learn/rendering-lists.md Outdated Show resolved Hide resolved
src/content/learn/rendering-lists.md Outdated Show resolved Hide resolved
src/content/learn/rendering-lists.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@vishnupprajapat vishnupprajapat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arshadkazmi42 I've fixed the minor comments you mentioned. Please review the changes

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Thank you for making all the changes.

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42 arshadkazmi42 merged commit 6f42e05 into reactjs:main Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants