Prevent duplicate Observation.stop with Micrometer #3976
Merged
+59
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents multiple `Observation.stop` calls with proper guardrails in `MicrometerObservationListener`. Since cancellation can happen out-of-band on a different `Thread`, a `volatile` state has been introduced to prevent duplicate `Observation` terminations. Resolves #3972 Signed-off-by: Dariusz Jędrzejczyk <[email protected]>
violetagg
approved these changes
Jan 27, 2025
|
@violetagg thank you for the review :) |
chemicL
added a commit
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents multiple
Observation.stopcalls with proper guardrails inMicrometerObservationListener. Since cancellation can happen out-of-band on a differentThread, avolatilestate has been introduced to prevent duplicateObservationterminations.Resolves #3972
As a side note, this is similar to the issue described in spring-projects/spring-framework#31417 and the solution is similar, yet more low level.