Configuration for setting maximum number of connection pools to be created #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnection pools a ConnectionProvider should create. Once the expected number is exceeded, a warning message is logged.
violetagg
requested changes
Dec 30, 2024
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java
Outdated
Show resolved
Hide resolved
violetagg
changed the title
violetagg
requested changes
Jan 3, 2025
reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java
Outdated
Show resolved
Hide resolved
reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java
Outdated
Show resolved
Hide resolved
reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java
Outdated
Show resolved
Hide resolved
reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java
Outdated
Show resolved
Hide resolved
reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java
Outdated
Show resolved
Hide resolved
reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java
Outdated
Show resolved
Hide resolved
…pClientTest.java Co-authored-by: Violeta Georgieva <[email protected]>
jchenga
force-pushed
the
3318-configuration-for-connection-pools-limit
branch
from
f64e1cd to
e3e5578
Compare
jchenga
force-pushed
the
3318-configuration-for-connection-pools-limit
branch
from
e3e5578 to
420dd1c
Compare
|
I have made the suggested changes. |
violetagg
requested changes
Jan 6, 2025
reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java
Outdated
Show resolved
Hide resolved
reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java
Outdated
Show resolved
Hide resolved
violetagg
reviewed
Jan 8, 2025
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java
Outdated
Show resolved
Hide resolved
violetagg
reviewed
Jan 8, 2025
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java
Outdated
Show resolved
Hide resolved
violetagg
added a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a configuration option to specify the maximum number of connection pools a
ConnectionProvidershould create. Once the maximum number is exceeded, a warning message is logged.Fixes #3318.