Use Adapter *Contents instead in File Node #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WyriHaximus Please restart the CI build. However the Directory Test failures are unrelated to this PR. |
|
@CharlotteDunois will kick them for a while, need to finish #78 to resolve this |
|
@CharlotteDunois all failing tests look EIO related to me |
clue
approved these changes
Apr 26, 2020
|
@clue This is already covered by the |
jsor
approved these changes
Apr 26, 2020
WyriHaximus
approved these changes
Apr 26, 2020
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
Node/Fileto use the methods on theAdapterInterfaceinstead of open the file for reading or writing and buffer the stream.Fixes #63.