-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: esm + tsup
#734
feat: esm + tsup
#734
Conversation
this is specific to tsup but ideally any build tool we use will yield a result that looks like this
hopefully we don't need this, but tsup needed something like this in my testing (but maybe not?)
i hate this song
thanks i hate it
Quick summary of the progress made in this PR thus far! I've gotten the functionality up and running where the
The SDK works and is fully typed for usage in TS and CJS, but needs #733 to be merged and published to the You can head over to this repo to see the sandbox environment I was testing this in. Next steps (non-exhaustive list, just rattling off stuff off the top of my head, doesn't all have to happen for this PR):
|
the merge conflicts with this on |
for posterity, this work has been continued in #754 |
🧰 Changes
TODO
ESNext
/bundler
in tsconfig for core subpackage (based on my reading, I think themoduleResolution
is the one that needs extra revisiting)Current blockers:
fetch-har
mismatched types (hopefully solved by feat: esm and cjs exports fetch-har#427):api/packages/core/src/index.ts
Line 126 in 0370988
exports
object remove-undefined-objects#86 fix: CJS export issue, CI cleanup remove-undefined-objects#88oas-to-har
mismatched types (I believe this was fixed by readmeio/oas-to-har@a342179, fix: another attempt to get lodash working oas-to-har#248 and a bunch of other messy PRs before that):api/packages/core/src/index.ts
Line 115 in 0370988
🧬 QA & Testing
Provide as much information as you can on how to test what you've done.