Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Spike on using
tshy
for the build — seems more strictly typed thantsup
(see this tweet from a TS maintainer)TODO
ESNext
/bundler
in tsconfig for core subpackage (based on my reading, I think themoduleResolution
is the one that needs extra revisiting)Current blockers:
@readme/api-core
isn't a module (we really gotta merge in feat: migrateapi
andcore
to ESM #733)🧬 QA & Testing
Provide as much information as you can on how to test what you've done.