Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: esm + tshy #747

Closed
wants to merge 2 commits into from
Closed

feat: esm + tshy #747

wants to merge 2 commits into from

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Sep 29, 2023

🚥 Resolves ISSUE_ID

🧰 Changes

Spike on using tshy for the build — seems more strictly typed than tsup (see this tweet from a TS maintainer)

TODO

  • Look into using ESNext / bundler in tsconfig for core subpackage (based on my reading, I think the moduleResolution is the one that needs extra revisiting)

Current blockers:

  • Figure out how to properly load in the spec file — currently we're in a catch-22 where the JSON import isn't being properly asserted and then import assertions aren't supported in CJS
  • @readme/api-core isn't a module (we really gotta merge in feat: migrate api and core to ESM #733)

🧬 QA & Testing

Provide as much information as you can on how to test what you've done.

@kanadgupta kanadgupta closed this Oct 6, 2023
@kanadgupta kanadgupta deleted the esm-tshy branch October 16, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant