feat(codegen): required devDeps are now listed in package.json
#761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
enhancement
erunion
changed the title
package.jsonpackage.json
erunion
changed the title
package.jsonpackage.json
erunion
changed the title
package.jsonpackage.json
erunion
force-pushed
the
refactor/codegen-dependencies
branch
from
5971aa0 to
540d869
Compare
erunion
commented
Oct 16, 2023
| reason: string; | ||
| url: string; | ||
| url?: string; |
There was a problem hiding this comment.
Made url optional because it feels silly to write out https://typescriptlang.org/ as the URL for TS.
erunion
commented
Oct 16, 2023
| @@ -28,8 +28,9 @@ export default abstract class CodeGenerator { | |||
| requiredPackages!: Record< | |||
| string, | |||
| { | |||
| dependencyType: 'production' | 'development'; | |||
There was a problem hiding this comment.
Made this as dependencyType instead of devDependency: boolean so it's not specific to NPM and Node.
kanadgupta
approved these changes
Oct 16, 2023
| @@ -28,8 +28,9 @@ export default abstract class CodeGenerator { | |||
| requiredPackages!: Record< | |||
| string, | |||
| { | |||
| dependencyType: 'production' | 'development'; | |||
| typescript: { | ||
| dependencyType: 'development', | ||
| reason: 'Required for `tsup`.', | ||
| version: '^5.2.2', |
There was a problem hiding this comment.
if and when we improve the codegen for our test fixtures (either via a build script or something), it'd be cool if we can dynamically pull in the versions from our dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Per feedback in #754 this slightly refactors the
package.jsonfile we generate for SDKs to now list the dev-only dependencies that are required to build an SDK.I've also added in a
preparescript to these for rebuilding the compiled SDK, as well as afilesarray for when/if a codegen'd SDK is published to NPM.