Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for esm #194

Merged
merged 3 commits into from
Sep 8, 2023
Merged

feat: added support for esm #194

merged 3 commits into from
Sep 8, 2023

Conversation

prisis
Copy link

@prisis prisis commented Aug 31, 2023 •
edited
Loading

🚥 Resolves ISSUE_ID

🧰 Changes

  • Added support for cjs and esm with tsup

🧬 QA & Testing

Check the output for cjs and esm

erunion
erunion requested changes Sep 2, 2023
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor nit but thank you so much for doing these.

tsup.config.ts Outdated Show resolved Hide resolved
@prisis @erunion
Update tsup.config.ts
ddb960c 
Co-authored-by: Jon Ursenbach <[email protected]>
@erunion erunion merged commit eba444c into readmeio:main Sep 8, 2023
6 checks passed
@prisis prisis deleted the added-esm-and-cjs-support branch September 11, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prisis @erunion