Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move swift from NSURLSession to URLSession #226

Merged
merged 14 commits into from
Apr 10, 2024

Conversation

zunda-pixel
Copy link

@zunda-pixel zunda-pixel commented Apr 10, 2024

🧰 Changes

  • Support Concurrency(Async/Await)
  • Replace to modern class from classic(NS) class
  • Support Code on Linux/Windows

Describe in detail what this PR is for.

🧬 QA & Testing

I fixed code in /httpsnippet/src/targets/swift/urlsession/fixtures/

npm run test

@zunda-pixel zunda-pixel marked this pull request as ready for review April 10, 2024 16:42
@erunion erunion self-requested a review April 10, 2024 16:43
@erunion erunion added the enhancement New feature or request label Apr 10, 2024
@erunion erunion requested review from a team, kanadgupta and darrenyong and removed request for a team April 10, 2024 16:43
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

src/targets/swift/target.ts Show resolved Hide resolved
@erunion erunion changed the title Replace to modern Swift feat: move swift from NSURLSession to URLSession Apr 10, 2024
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't have any experience with swift but this looks ok to me!

@erunion erunion merged commit 40c68dc into readmeio:main Apr 10, 2024
4 checks passed
@zunda-pixel zunda-pixel deleted the replace-to-modern-swift branch April 11, 2024 10:26
@zunda-pixel
Copy link
Author

@erunion
Will this changes be merged into readme.com?

@erunion
Copy link
Member

erunion commented Apr 11, 2024

@zunda-pixel This should be available on ReadMe customer sites sometime next week.

@zunda-pixel
Copy link
Author

@erunion thanks!

@erunion
Copy link
Member

erunion commented Apr 15, 2024

@zunda-pixel This work is now available on ReadMe customer sites. Thanks again!

@zunda-pixel
Copy link
Author

@erunion thanks! let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants