Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support timeout in Swift #229

Merged
merged 11 commits into from
Apr 12, 2024
Merged

Support timeout in Swift #229

merged 11 commits into from
Apr 12, 2024

Conversation

zunda-pixel
Copy link

🧰 Changes

  • support timeout paramater
  • remove final newline
  • remove FoundationNetworking
  • remove extra code in multipart/form-data

🧬 QA & Testing

I fixed test code in /httpsnippet/src/targets/swift/urlsession/fixtures/

npm run test

@zunda-pixel zunda-pixel marked this pull request as ready for review April 12, 2024 17:58
@erunion erunion merged commit e3a78da into readmeio:main Apr 12, 2024
4 checks passed
@zunda-pixel zunda-pixel deleted the support-timeout branch April 12, 2024 18:17
@erunion
Copy link
Member

erunion commented Apr 12, 2024

Published to 10.0.4!

I'm not sure if you're up for it, or if it's even feasible, but it would be amazing to have Swift as part of our integration test suite.

@zunda-pixel
Copy link
Author

I will try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants