test: migrate from nock to MSW #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
commented
Aug 22, 2023
|
|
||
| import * as crypto from 'crypto'; | ||
| import { createServer } from 'http'; | ||
|
|
||
| import chai, { expect } from 'chai'; | ||
| import chaiAssertionsCount from 'chai-assertions-count'; |
There was a problem hiding this comment.
had to bring this package in since mocha/chai doesn't have an equivalent for expect.assertions 🙃
erunion
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This PR moves us our HTTP mocking library from
nocktomswfor several reasons:apiSDK usage in fix: unified snippet QA #902). It seems likenockis not really getting that much investment anymore, see Node 18+: makenockwork nativefetchnock/nock#2397It took a bit for it to grow on me since I'm used to nock's batteries-included approach but its API has grown on me 😌
🧬 QA & Testing
I'm seeing some unrelated PHP build errors, but it appears the Node tests are passing so we should be good to go if folks are cool with us using this package!