Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example-groups file to preview site #108

Closed
wants to merge 1 commit into from

Conversation

darrenyong
Copy link
Contributor

🚥 Resolves ISSUE_ID

🧰 Changes

Adds an example groups file so we can bring it into the preview site!

🧬 QA & Testing

Provide as much information as you can on how to test what you've done.

@darrenyong darrenyong requested review from kanadgupta and erunion May 16, 2024 17:54
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a flag, i added a few example groups in #102 and #106!

Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion but otherwise lgtm. let me know when this is merged in and i'll tag a release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to rename this to readme-extensions-example-groups, or something similar, so it's clearer it's for our custom extension?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually going to close this out cause saw Kanad already added it in #102! beat me to it 😅

@darrenyong
Copy link
Contributor Author

#108 (comment)

@darrenyong darrenyong closed this May 16, 2024
@darrenyong darrenyong deleted the darren/add-example-groups-files branch May 16, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants