feat: add discriminator example from redocly #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
approved these changes
Aug 27, 2024
Co-authored-by: Jon Ursenbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Redocly supports the usage of discriminator mappings that don't use
anyOforoneOfto explicitly define the objects 😵💫 this seems like a divergence from the OpenAPI specification (even Swagger UI doesn't support this):... but this is a paradigm that users are expecting us to support (more context here). This PR adds an example of this kind of setup.
🧬 QA & Testing
Confirmed this is valid locally per
rdme! And that it renders in both Redocly and ReadMe as I would expect.For posterity, here's the new endpoint on our bin site: https://bin.readme.com/s/66ce3b9b46829b006ee0cee6