Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oas-to-har): reducing the lodash footprint #823

Merged
merged 1 commit into from
Oct 20, 2023
Merged

feat(oas-to-har): reducing the lodash footprint #823

merged 1 commit into from
Oct 20, 2023

Conversation

erunion
Copy link
Member

@erunion erunion commented Oct 20, 2023

🚥 Resolves #815

🧰 Changes

This slightly reduces our lodash footprint in oas-to-har by loading the dedicated packages for lodash.get and lodash.set instead of grabbing those methods out of the larger package.

#815 also was curious about removing qs in favor of URLSearchParams because URLSearchParams doesn't support deep objects the same way qs does.

@erunion erunion added the refactor Issues about tackling technical debt label Oct 20, 2023
@erunion erunion requested a review from kanadgupta October 20, 2023 19:11
@erunion erunion marked this pull request as ready for review October 20, 2023 19:11
@erunion erunion merged commit 9412821 into main Oct 20, 2023
@erunion erunion deleted the feat/reduce-lodash-footprint branch October 20, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanadgupta kanadgupta Awaiting requested review from kanadgupta

Assignees
No one assigned
Labels
refactor Issues about tackling technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce external dependency usage
1 participant
@erunion