Skip to content

Commit

Permalink
fix: CJS export issue, CI cleanup (#88)
Browse files Browse the repository at this point in the history
* fix: remove problematic flag

tsup already treeshakes! this flag is causing discrepancies with the CJS build vs types

* ci: re-add typechecking
  • Loading branch information
kanadgupta authored Sep 21, 2023
1 parent 6bc59f1 commit 17a9557
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,4 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- run: npm ci
- run: npm run build
- run: npm test
- run: npm cit
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@
},
"scripts": {
"build": "tsup",
"lint": "eslint . --ext .js,.ts",
"lint": "tsc --noEmit && eslint . --ext .js,.ts",
"prebuild": "rm -rf dist/",
"prepack": "npm run build",
"prepare": "husky install",
"pretest": "npm run build; npm run lint",
"pretest": "npm run lint",
"prettier": "prettier --list-different --write \"./**/**.{js,ts}\"",
"test": "vitest --coverage"
"test": "vitest run --coverage"
},
"devDependencies": {
"@commitlint/cli": "^17.6.5",
Expand Down
1 change: 0 additions & 1 deletion tsup.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@ export default defineConfig((options: Options) => ({
silent: !options.watch,
sourcemap: true,
splitting: true,
treeshake: true,
}));

0 comments on commit 17a9557

Please sign in to comment.