fix: more error handling for files that will never contain docblocks #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow on from this PR: #196 which added support for ignoring `multiline-extract-comments` from markdown files. We only accounted for `.md` extensions and not `.markdown`, which is also valid. This will fix an error upstream in the readme-micro action which uses swagger-inline to try and extract openapi operations from code.
erunion
approved these changes
Jul 17, 2024
erunion
approved these changes
Jul 17, 2024
domharrington
added a commit
to readmeio/readme-micro
that referenced
this pull request
Jul 17, 2024
Fixes an issue coming from there: readmeio/swagger-inline#321
gkoberger
pushed a commit
to readmeio/readme-micro
that referenced
this pull request
Jul 17, 2024
## 🧰 Changes Fixes an issue coming from there: readmeio/swagger-inline#321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Follow on from this PR: #196 which added support for ignoring
multiline-extract-commentsfrom markdown files. We only accounted for.mdextensions and not.markdown, which is also valid.This will fix an error upstream in the readme-micro action which uses swagger-inline to try and extract openapi operations from code.
🧬 QA & Testing
Do the tests pass?