feat(front): improve bin deletion UX #157
Conversation
There was a problem hiding this comment.
Frankly I don't know, like a service worker is something I consider huge, I really don't feel easy giving my approval on this one, nor I feel easy rejecting the changes because it do works and it's a feature that have long been requested by users.
My only comment it that it definitely deserve more effort documentation-wise. Maybe add a link to online resources we can study to understand how it works. Also still documentation-wise, it would be great you explain all our attempts to make this one work and to re-state the "user-story" of this branch.
I delegate my review to someone who knows more than I do on this piece of technology.
|
When you'll resolve the conflict, could you add a comment for the |
Done |
|
Still waiting for a third person to review and test this branch! |
|
cc @fusetim or anyone who wants to test this. |
|
Might take a while for me |
|
bump @Julien00859? |
|
De mon côté le bouton de suppression de bin ne s'affiche pas |
| @@ -6,7 +6,10 @@ | |||
| <link rel=stylesheet href="/assets/styles/monokai.css"> | |||
| <script src="/assets/scripts/loc.js" defer></script> | |||
| <script src="/assets/scripts/report.js" defer></script> | |||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/localforage/1.10.0/localforage.min.js" defer></script> | |||
| <script src="/assets/scripts/delete.js" defer type=module></script> | |||
There was a problem hiding this comment.
Le type module n'est pas nécessaire et empêche le chargement a cause d'un type mime invalide
D'ailleurs les autres scripts sont chargés avec un type mime invalide aussi, mais ça ne provoque qu'un warn tant que ce n'est pas chargé en tant que module
| const deleteButton = document.getElementById('delete-button'); | ||
| const id = location.pathname.slice(1, location.pathname.lastIndexOf('.')); | ||
|
|
||
| const token = await localforage.getItem(id); |
There was a problem hiding this comment.
un await en dehors d'une fonction async empêche l'exécution du script
The bin deletion via the interface was completly impratical. From now on, the token storage is done automatically. Indeed, a Service Worker is registered to intercept in particular the request of the form and the request of the final page (redirection). This allows to associate the token with the bin ID, which is not known in advance. In the background, the IndexedDB database is used via the `localforage` abstraction, which allows to easily store key-value in the same way as the `localStorage` (which is not available in a Service Worker). This feature is only available for the clients with JavaScript enabled. Closes: readthedocs-fr#147.
Mesteery
force-pushed
the
better-bin-deletion-ux
branch
from
00444da
to
8381df4
Compare
The bin deletion via the interface was completly impratical.
From now on, the token storage is done automatically.
Indeed, a Service Worker is registered to intercept in particular
the request of the form and the request of the final page (redirection).
This allows to associate the token with the bin ID, which is not known
in advance.
In the background, the IndexedDB database is used via the
localforageabstraction, which allows to easily store key-value in the same way as
the
localStorage(which is not available in a Service Worker).This feature is only available for the clients with JavaScript enabled.
Closes: #147.