This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
Add multi-platform coverage to our unit tests(cyberflow) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
just need to coordinate with @realityforge to get Travis building PRs again. |
|
Okay - I think it has all been re-enabled. Kick me if you need me to do anything more. |
mburns
force-pushed
the
mburns/cyberflow/unit-tests
branch
2 times, most recently
from
30435c7 to
159def6
Compare
# This is the 1st commit message: update rubocop # This is the commit message realityforge#2: update rubocop length allowances
enforce version 3 on kibana3 unit tests
mburns
force-pushed
the
mburns/cyberflow/unit-tests
branch
from
159def6 to
5232403
Compare
mburns
force-pushed
the
mburns/cyberflow/unit-tests
branch
from
38416ec to
3f33663
Compare
|
Passes unit tests. There are some issues with package installs on some of the integration tests. Will need to address those before cutting a new release. |
melchiormoulin
pushed a commit
to criteo-forks/chef-kibana
that referenced
this pull request
Nov 15, 2018
realityforge#111 chef_nginx -> nginx realityforge#112 fix tests on multiple platforms
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor/cherry-pick logic from #101 with respect to unit tests (and basic tooling/chef12 compatibility).
Currently, the majority of our unit tests only run against Ubuntu. We should run all tests against the platforms we claim to support (ubuntu 14/16, centos 6/7).
TODO