cwltool: upgrade to the latest version #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 24.81% 25.04% +0.22%
==========================================
Files 10 10
Lines 548 551 +3
==========================================
+ Hits 136 138 +2
- Misses 412 413 +1
|
audrium
commented
Jul 13, 2021
| @@ -280,6 +280,13 @@ def shouldquote(x): | |||
|
|
|||
| return create_body | |||
|
|
|||
| def _required_env(self): | |||
There was a problem hiding this comment.
audrium
force-pushed
the
cwl-upgrade
branch
2 times, most recently
from
ecef29a to
56e3cc1
Compare
tiborsimko
reviewed
Aug 30, 2021
tiborsimko
reviewed
Aug 30, 2021
| @@ -53,7 +37,6 @@ def run_cwl_workflow_engine_adapter( | |||
| **kwargs, | |||
| ): | |||
| """Run cwl workflow.""" | |||
| workflow_parameters = parse_str_to_int(workflow_parameters) | |||
There was a problem hiding this comment.
BTW seeing the removal of parameters made me want to retest the partial workflow execution concept. We seem to have troubles there:
$ reana-client run -f ./reana-cwl.yaml -w partial -o TARGET=gendata
...
partial.1 has been queued
$ reana-client logs -w partial
==> Workflow engine logs
Workflow exited unexpectedly.
Not found: 'TARGET'Also:
$ reana-client restart -w partial -o TARGET=gendata
Cannot start workflow partial:
==> ERROR: Operational option "--target" not supported.But I guess it may not be working properly in master either...
Have you been looking at similar "target" possibilities while upgrading the cwltool version? If not, shall we create a new issue and test it separately from this PR set? (as it is otherwise good to go?)
There was a problem hiding this comment.
I actually haven't tested this.. Created a new issue to address this trouble
tiborsimko
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #187
reana-dev run-example -w cwlworks as expected