fix: remove untrue check related to option(_) labelled props

reasonml · Oct 21, 2023 · 342a6b7 · 342a6b7
1 parent 30fec6b
commit 342a6b7
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 27 deletions.
diff --git a/ppx/reason_react_ppx.ml b/ppx/reason_react_ppx.ml
@@ -639,29 +639,6 @@ let jsxMapper =
           default,
           pattern,
           expression ) ->
-        let () =
-          match (arg, pattern, default) with
-          | Optional _, { ppat_desc = Ppat_constraint (_, { ptyp_desc }) }, None -> (
-              match ptyp_desc with
-              | Ptyp_constr ({ txt = Lident "option" }, [ _ ]) -> ()
-              | _ ->
-                  let currentType =
-                    match ptyp_desc with
-                    | Ptyp_constr ({ txt }, []) ->
-                        String.concat "." (Longident.flatten_exn txt)
-                    | Ptyp_constr ({ txt }, _innerTypeArgs) ->
-                        String.concat "." (Longident.flatten_exn txt) ^ "(...)"
-                    | _ -> "..."
-                  in
-                  Ocaml_common.Location.prerr_warning pattern.ppat_loc
-                    (Preprocessor
-                       (Printf.sprintf
-                          "reason-react-ppx: optional argument annotations \
-                           must have an explicit `option` type. Did you mean \
-                           `option(%s)=?`?"
-                          currentType)))
-          | _ -> ()
-        in
         let alias =
           match pattern with
           | { ppat_desc = Ppat_alias (_, { txt }) | Ppat_var { txt } } -> txt

diff --git a/ppx/test/optional-arg-check.t b/ppx/test/optional-arg-check.t
@@ -23,10 +23,6 @@ Demonstrate how to use the React JSX PPX
 
   $ dune build @mel
   File "x.re", line 3, characters 15-27:
-  3 |   let make = (~myProp: bool=?) => React.null;
-                     ^^^^^^^^^^^^
-  Warning 22 [preprocessor]: react-jsx-ppx: optional argument annotations must have an explicit `option` type. Did you mean `option(bool)=?`?
-  File "x.re", line 3, characters 15-27:
   3 |   let make = (~myProp: bool=?) => React.null;
                      ^^^^^^^^^^^^
   Error: This pattern matches values of type bool