-
Notifications
You must be signed in to change notification settings - Fork 428
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Problem: There exists reason packages in the wild that have `omp: *` as a dependency. A new breaking change was released in omp 2.0.0. We cannot compile against it. We also cannot upgrade to the intended replacement for the old functionality we were using `ppxlib` because it doesn't support older versions of omp. The only solution is to vendor. This should unbreak existing libraries that depend on older versions of Reason. We should have had a constraint of `omp: < 2.0.0`, but even in that case the package ecosystem essentially breaks because it splits into two sides - ones that can use 2.0.0 omp and ones that cannot. Vendoring omp solves that problem. It might not work during the next compiler upgrade though (estimated six months). Test Plan: Reviewers: CC:
- Loading branch information
Showing
208 changed files
with
76,751 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.