Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change fast-equals to fast-deep-equal; 1kb less #104

Closed
wants to merge 1 commit into from

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Dec 4, 2024

Package fast-deep-equal is the most npm popular (50M) and top-fast (https://github.com/epoberezkin/fast-deep-equal)

Profit: less for 1 kB

@denisx
Copy link
Contributor Author

denisx commented Dec 4, 2024

@ckifer sorry for ping (or suggest me another maintainer)

@ckifer
Copy link
Member

ckifer commented Dec 4, 2024

Hey @denisx

This has been suggested before. Even though fast-deep-equal is the most popular it is essentially an abandoned project which we would rather not depend on

epoberezkin/fast-deep-equal#145

@ckifer ckifer closed this Dec 4, 2024
@denisx
Copy link
Contributor Author

denisx commented Dec 5, 2024

What about react-fast-compare ? @ckifer

@denisx denisx deleted the feat/equals branch December 5, 2024 11:27
@ckifer
Copy link
Member

ckifer commented Dec 5, 2024

That looks better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants