Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing adapter forwarding to the createSelectionState #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oleksandr-danylchenko
Copy link
Contributor

Issue

The createTextAnnotatorState wasn't forwarding the provided adapter to the createSelectionState. That led to the missing serialization on the onUserSelect call.

Example

image
However, an internal type is provided to the userSelectActionCallback:
image

Changes Made

Added opts.adapter forwarding to the createSelectionState. That makes the code compatible with the API changes made in annotorious/annotorious@79c7b17.
I borrowed that approach from the a9s/a9s's createImageAnnotator, which passes the whole opts object to the createImageAnnotatorState, source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant