Added missing adapter
forwarding to the createSelectionState
#187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
createTextAnnotatorState
wasn't forwarding the providedadapter
to thecreateSelectionState
. That led to the missing serialization on theonUserSelect
call.Example
However, an internal type is provided to the
userSelectActionCallback
:Changes Made
Added
opts.adapter
forwarding to thecreateSelectionState
. That makes the code compatible with the API changes made in annotorious/annotorious@79c7b17.I borrowed that approach from the
a9s/a9s
'screateImageAnnotator
, which passes the wholeopts
object to thecreateImageAnnotatorState
, source.