Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: check response always, not only through makeRequest #674

Open
wants to merge 7 commits into
base: v3-v2021-02-25
Choose a base branch
from
Open

improvement: check response always, not only through makeRequest #674

wants to merge 7 commits into from

Commits on Sep 28, 2021

  1. feat: allow for http adapter param 

    - Base client class now accepts Http Adapter object as param.
- Add http adapter interface
    @saas786
    saas786 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    774dc86 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Merge remote-tracking branch 'github-saas/syed/v3-v2021-02-25/guzzle'… 

    … into v3-v2021-02-25:

- Added HttpAdapterInterface
    Sinus committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    e20809e View commit details
    Browse the repository at this point in the history

  2. Revert "Merge remote-tracking branch 'github-saas/syed/v3-v2021-02-25… 

    …/guzzle' into v3-v2021-02-25:"

This reverts commit e20809e, reversing
changes made to d62bdf2.
    Sinus committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    1071e2f View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Fallback to guessing error type from HTTP status code even if "Conten… 

    …t-Type: application/json" was received in header.
    Sinus committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    11d8872 View commit details
    Browse the repository at this point in the history

  2. Check response validity always, not just on toResource, 

    so that makeRequest AND pagerCount are validated.
    Sinus committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    c66fd99 View commit details
    Browse the repository at this point in the history

  3. Fixed response test to verify assertion, not toResource erroring out,… 

    … because toResource no longer throws errors - makeRequest does.
    Sinus committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    7caf7ce View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Merge branch 'v3-v2021-02-25' into issue--check-response-always

    @SinusPi
    SinusPi authored Mar 15, 2022
    Configuration menu
    Copy the full SHA
    3acc614 View commit details
    Browse the repository at this point in the history