Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Earmark feature tests #4368

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Earmark feature tests #4368

merged 1 commit into from
Jan 28, 2025
+225 −1

Conversation

Harishacharya-redhat
Copy link
Contributor

@Harishacharya-redhat Harishacharya-redhat changed the title Earmark feature Earmark feature tests Jan 9, 2025
@Harishacharya-redhat Harishacharya-redhat marked this pull request as ready for review January 9, 2025 12:26
msainiRedhat
msainiRedhat previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@msainiRedhat msainiRedhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 9, 2025
pranavprakash20
pranavprakash20 requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@pranavprakash20 pranavprakash20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have a look at the comments.

@openshift-ci openshift-ci bot removed the lgtm Add this label when the PR is good to be merged label Jan 13, 2025
@Harishacharya-redhat Harishacharya-redhat added the work-in-progress work in progress label Jan 15, 2025
@Harishacharya-redhat Harishacharya-redhat requested review from a team as code owners January 15, 2025 13:49
@openshift-ci openshift-ci bot removed the lgtm Add this label when the PR is good to be merged label Jan 21, 2025
msainiRedhat
msainiRedhat previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@msainiRedhat msainiRedhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 21, 2025
MohitBis
MohitBis previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@MohitBis MohitBis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vamahaja
vamahaja requested changes Jan 24, 2025
View reviewed changes
cli/ceph/fs/sub_volume.py Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Add this label when the PR is good to be merged label Jan 24, 2025
@Harishacharya-redhat Harishacharya-redhat force-pushed the earmark_feature branch 2 times, most recently from 37fa549 to 07427f3 Compare January 28, 2025 06:36
@Harishacharya-redhat
adding earmark related test cases
b93ca03 
Signed-off-by: Harishacharya-redhat <[email protected]>
pranavprakash20
pranavprakash20 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@pranavprakash20 pranavprakash20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 28, 2025
MohitBis
MohitBis approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@MohitBis MohitBis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msainiRedhat
Copy link
Contributor

LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Harishacharya-redhat, MohitBis, msainiRedhat, pranavprakash20, vamahaja

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit 952bf1d into red-hat-storage:main Jan 28, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harish-Vishwakarma Harish-Vishwakarma Harish-Vishwakarma left review comments

@pranavprakash20 pranavprakash20 pranavprakash20 approved these changes

@MohitBis MohitBis MohitBis approved these changes

@vamahaja vamahaja vamahaja approved these changes

@msainiRedhat msainiRedhat msainiRedhat approved these changes

@vdas-redhat vdas-redhat Awaiting requested review from vdas-redhat vdas-redhat is a code owner

@mkasturi18 mkasturi18 Awaiting requested review from mkasturi18

@ckulal ckulal Awaiting requested review from ckulal

@TejasC88 TejasC88 Awaiting requested review from TejasC88

Assignees

@msainiRedhat msainiRedhat

@vamahaja vamahaja

@MohitBis MohitBis

@pranavprakash20 pranavprakash20

Labels
lgtm Add this label when the PR is good to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Harishacharya-redhat @psathyan @msainiRedhat @Harish-Vishwakarma @vamahaja @MohitBis @pranavprakash20