[LibFix] Limit certificate installation to baremetal nodes #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamahaja
requested review from
Adarsha1999,
psathyan,
tintumathew10 and
deepssin
vamahaja
changed the title
install_prereq.pyinstall_prereq.py
psathyan
reviewed
Jan 27, 2025
deepssin
previously approved these changes
Jan 27, 2025
vamahaja
force-pushed
the
fix-cert-update
branch
from
a7ed573 to
602e276
Compare
openshift-ci
bot
removed
the
lgtm
vamahaja
changed the title
install_prereq.py
RCA: Updating certficates steps are part of inventory file which executes when nodes are deployed. Same steps are executed in `misc_env/install_prereq.py` with incorrect certificates. Fix certificate paths and limit steps to add certificates from library for baremental. Signed-off-by: Vaibhav Mahajan <[email protected]>
vamahaja
force-pushed
the
fix-cert-update
branch
from
602e276 to
6c5be33
Compare
psathyan
approved these changes
Jan 30, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: psathyan, vamahaja The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA:
Updating certficates steps are part of inventory file which executes when nodes are deployed. Same steps are executed in
misc_env/install_prereq.pywith incorrect certificates.Fix certificate paths and limit steps to add certificates from library for baremental.