Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify IPv6 Connectivity Between Rook-Ceph-Exporter and OCP Prometheus #11480

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

OdedViner
Copy link
Contributor

Description:

This PR introduces a test to verify the connectivity of rook-ceph-exporter pods to OpenShift Prometheus over IPv6.

Test Procedure:

  1. Retrieve the IPv6 addresses of rook-ceph-exporter pods.
  2. Identify the prometheus-k8s pod in the openshift-monitoring namespace.
  3. Use curl from within the prometheus-k8s pod to access the /metrics endpoint of each exporter via IPv6.
  4. Verify that the response contains the expected Ceph metric: ceph_AsyncMessenger_Worker_msgr_connection.

@OdedViner OdedViner requested a review from a team as a code owner February 24, 2025 12:29
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Feb 24, 2025
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: oviner23-feb
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w_ipv6.yaml
PR Test Suite: tier1
PR Test Path: tests/functional/monitoring/prometheus/metrics/test_monitoring_defaults.py::test_monitoring_ipv6
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: oviner23-feb
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w_ipv6.yaml
PR Test Suite: tier1
PR Test Path: tests/functional/monitoring/prometheus/metrics/test_monitoring_defaults.py::test_monitoring_ipv6
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

@tier1
@bugzilla("2297285")
@pytest.mark.polarion_id("OCS-XXX")
def test_monitoring_ipv6(threading_lock):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no rook-ceph-exporter on External mode clusters because rook does not manage ceph in this case.
I think this test is irrelevant to External mode and we may add "skip_if" decorator

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tier1
@bugzilla("2297285")
@pytest.mark.polarion_id("OCS-XXX")
def test_monitoring_ipv6(threading_lock):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we check if ipv6 feature enabled on deployment before running this test? if not we may want to skip.
we'll probably need to add marker for ipv6_enabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a condition for IPv4 so that the test now supports both IPv6 and IPv4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it in most cases will check on ipv4 (our default environment now) should not we rename test?

test_monitoring_ipv6 -> test_monitoring_ip_version , or something similar

Signed-off-by: Oded Viner <[email protected]>
Signed-off-by: Oded Viner <[email protected]>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: oviner23-feb
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w_ipv6.yaml
PR Test Suite: tier1
PR Test Path: tests/functional/monitoring/prometheus/metrics/test_monitoring_defaults.py::test_monitoring_ipv6
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

Copy link

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, OdedViner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M PR that changes 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants