Initial commit of volume migration tool #2598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
jarrpa
force-pushed
the
jarrpa/vol-mv-dump
branch
19 times, most recently
from
9ec3ec6
to
783e2dc
Compare
|
/retest |
jarrpa
force-pushed
the
jarrpa/vol-mv-dump
branch
6 times, most recently
from
92acd85
to
84f8bb1
Compare
jarrpa
force-pushed
the
jarrpa/vol-mv-dump
branch
2 times, most recently
from
d31f76a
to
f393603
Compare
|
/retest |
|
/retest |
1 similar comment
|
/retest |
openshift-merge-robot
added
the
needs-rebase
jarrpa
force-pushed
the
jarrpa/vol-mv-dump
branch
from
f393603
to
c61629b
Compare
Previously, the paths given to controller-gen have it scanning all go packages in the repo for relevant kubebuilder markers. This can cause problems with parts of the repo that may need additional libraries installed in the runtime environment but are not required for the operator or its bundle manifests. Limiting controller-gen to only scan the directories that are actually relevant to its functionality resolves this, and just seems like a good idea in general. Signed-off-by: Jose A. Rivera <[email protected]>
jarrpa
force-pushed
the
jarrpa/vol-mv-dump
branch
from
c61629b
to
677a3ca
Compare
openshift-merge-robot
removed
the
needs-rebase
jarrpa
force-pushed
the
jarrpa/vol-mv-dump
branch
from
677a3ca
to
5bf733b
Compare
At the moment, this tool is not guaranteed to work as intended across all environments. This commit is to help start integrating the tool into our CI/CD pipelines, and also to verify that it doesn't break anything for the rest of the repo. Signed-off-by: Jose A. Rivera <[email protected]>
Signed-off-by: Jose A. Rivera <[email protected]>
jarrpa
force-pushed
the
jarrpa/vol-mv-dump
branch
from
5bf733b
to
029ba52
Compare
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an initial set of commits for a volume migration tool for OCS.
At the moment the tool is not guaranteed to work, and thus I'm not looking for a review of the code itself. The main purpose of this PR is to verify that committing it to the repo doesn't break the CI or development environment of other contributors. It is also intended to get the tool integrated into downstream CD/CI pipelines.
Signed-off-by: Jose A. Rivera [email protected]