Fix broken watch for CRDs on storageCluster controller #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The watch had builder.WithPredicates twice, which was causing the watch to not work as expected. Thus even after the CRD was created the controller was not able to detect it and queue a reconcile. Now the predicates are combined under one builder.WithPredicates. Signed-off-by: Malay Kumar Parida <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leelavg, malayparida2000 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leelavg
reviewed
Nov 28, 2024
| @@ -235,8 +235,6 @@ func (r *StorageClusterReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| builder.WithPredicates( | |||
There was a problem hiding this comment.
or should this use util.ComposePredicates? I don't remember does the default one allows any match or all matches.
|
https://issues.redhat.com/browse/DFBUGS-726, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The watch had builder.WithPredicates twice, which was causing the watch to not work as expected. Thus even after the CRD was created the controller was not able to detect it and queue a reconcile. Now the predicates are combined under one builder.WithPredicates.