modulize #41
Open
modulize #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Separating the code in main which specifies the exact -patches branch can be moved to a different method. |
bigjust
requested changes
Aug 22, 2022
bigjust
requested changes
Aug 25, 2022
rdopkg_tar/tar_changes.py
Outdated
Comment on lines
157
to
161
| def parse_args(parsed_params): | ||
| """ | ||
| parse args from the spec file and assign to the collection parsed_params | ||
| args assigned: branch, patches_branch, changes, tarball, osdist, args | ||
| """ |
There was a problem hiding this comment.
I'd rather initialize parsed_params in the parse_args function, we can just return it
rdopkg_tar/tar_changes.py
Outdated
Comment on lines
230
to
231
| params = parsed_params(branch, patches_branch, changes, tarball, osdist, args) | ||
|
|
There was a problem hiding this comment.
You can just return parsed_params(...) here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modulize main function, pls recommend suggested changes.