Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Code Rewrite #118

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Button Code Rewrite #118

wants to merge 3 commits into from

Commits on Sep 13, 2024

  1. Refactored button turning code 

    -Now uses Drivers/lib/mqtt_client.py MQTT client code instead of own.

-Rewrote most code to use event listening for button presses instead of looping & sleeping

-Moved button code into own driver folder: button_control

-Created new MQTT topic - bike/{ID}/button - for button communication.

-Now uses parsed arguments from script with defaulting to environment variables rather than hardcoded values.
    @KasparByrne
    KasparByrne committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5bdb7fe View commit details
    Browse the repository at this point in the history

  2. Change to button topic for consistency 

    -Changed to use report sub-topic instead of control sub-topic as the buttons only "sense"
    @KasparByrne
    KasparByrne committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    adb85fa View commit details
    Browse the repository at this point in the history

  3. Import lib cleaner fix 

    - turns out there was a much cleaner way to import the mqtt_client from lib.
    @KasparByrne
    KasparByrne committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b802092 View commit details
    Browse the repository at this point in the history