Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo clean up and retiring old code #119

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Sep 13, 2024

  1. Refactored button turning code

    -Now uses Drivers/lib/mqtt_client.py MQTT client code instead of own.
    
    -Rewrote most code to use event listening for button presses instead of looping & sleeping
    
    -Moved button code into own driver folder: button_control
    
    -Created new MQTT topic - bike/{ID}/button - for button communication.
    
    -Now uses parsed arguments from script with defaulting to environment variables rather than hardcoded values.
    KasparByrne committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5bdb7fe View commit details
    Browse the repository at this point in the history
  2. Change to button topic for consistency

    -Changed to use report sub-topic instead of control sub-topic as the buttons only "sense"
    KasparByrne committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    adb85fa View commit details
    Browse the repository at this point in the history
  3. Import lib cleaner fix

    - turns out there was a much cleaner way to import the mqtt_client from lib.
    KasparByrne committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b802092 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Retiring old code + restructuring to clean up the repo

    - Moved old research into archive folder.
    
    - Moved old drivers that were no longer relevant to archive folder.
    
    - Moved unused Unity project in IoT repo (believe this may be the old game which is no longer being developed) to archive folder.
    
    - Moved remote connect code, due to breaking and being undocumented, to archive folder.
    
    - Moved workout drivers into own sub folder in Drivers folder since a lot of them are no longer relevant but we may want to take inspiration from them for the mobile app.
    
    **This looks super scary but everything is being preserved and just dumped into the archive folder for later exploration or use if needed.** The repo is currently very cluttered with redundant and abandoned projects and research. This makes it very difficult to discover relevant code when combined with the lack of documentation.
    KasparByrne committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    87c3e18 View commit details
    Browse the repository at this point in the history