crux_time API improvement #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charypar
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
I think I agree with this - allowing the ID to be set was an oversight 🙈
@StuartHarris any opinions?
|
Yes I agree. Thanks @adwhit ! |
|
While we're breaking things, refactoring |
wanna do that before we merge it? |
|
Yep done |
charypar
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Happy with this, thank you!
/cc @StuartHarris this will be a breaking change to the time capability once more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion to remove the
id: TimerIdargument from variouscrux_timeAPIs. In my opinion it doesn't make sense to provide this value, it should be considered an opaque type useful only insidecrux_time(so perhaps consider removing the ability to independently createTimerIds too). YMMV!Obviously this is a breaking change.