Skip to content

Commit

Permalink
Backup all resources in toolchain member namespace (#4652)
Browse files Browse the repository at this point in the history
Backing up a list of resources can lead to incomplete backup, e.g. if a
CRD is added without updating the back up list.

To be on the safe side, change the backup to include all resources in
toolchain-member-operator and restore procedure will explicitly mention
which resources to restore. Doing it that way will cost a bit more on
the AWS storage but has the huge advantage of covering the case of CRD
being added later. Backup will include it and restore procedure might
not but can be adjusted when restore is performed.

KFLUXINFRA-730

Signed-off-by: Hugo Ares <[email protected]>
  • Loading branch information
hugares authored Oct 4, 2024
1 parent a8ebf8e commit 54d61fc
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ metadata:
spec:
schedule: 30 1,13 * * * # every day 1:30, 13:30 UTC
template:
includedResources:
- spacebindingrequests.toolchain.dev.openshift.com
- spacerequests.toolchain.dev.openshift.com
includedNamespaces:
- toolchain-member-operator
storageLocation: velero-aws-1
ttl: 720h0m0s
useOwnerReferencesInBackup: true

0 comments on commit 54d61fc

Please sign in to comment.