Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs fixes and updates #2315

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dustinblack
Copy link
Contributor

Fixes and updates to the development/deployment.md docs for better clarity of how to work with a preview bootstrap.

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

Hi @dustinblack. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dustinblack, Michkov
Once this PR has been reviewed and has the lgtm label, please assign alexeykazakov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved label Oct 17, 2023
@Roming22
Copy link
Member

@mmorhun Looks like this PR has been pending for a while after being approved by Michal. Can you please double check the content, and we'll try to have it go through.

@Roming22
Copy link
Member

Roming22 commented Jan 9, 2024

@dustinblack Can you follow up on this PR? It's been opened for a while with no progress.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustinblack
Copy link
Contributor Author

@dustinblack Can you follow up on this PR? It's been opened for a while with no progress.

I haven't touched this project in a year. I wouldn't know if the docs updates I made are still relevant, but I do think someone should take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants