Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install knative-eventing instead knative-eventing-core #4974

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maruiz93
Copy link

  • KubeArchive needs knative-eventing instead knative-eventing-core now that brokers are introduced
  • KubeArchive is using in-memory brokers by default which we think is enough. If you think Konflux need more performant brokers like Kafka those should be included.

Copy link

openshift-ci bot commented Nov 25, 2024

Hi @maruiz93. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rh-hemartin
Copy link
Contributor

/ok-to-test

@rh-hemartin
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maruiz93, rh-hemartin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rh-hemartin
Copy link
Contributor

/test appstudio-e2e-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants