Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message fixture to conftest #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaayanMashhadi
Copy link
Collaborator

@MaayanMashhadi MaayanMashhadi commented Jun 7, 2023

Desired Outcome

one fixture of message in conftest and rename the message fixture from saved_message to message,
will make the code more readable.

Implemented Changes

  1. message fixture added to conftest.
  2. removing the saved_message fixture from message test
  3. rename the saved_message fixture to be message.

Connected Issue/Story

Resolves #115
Resolves #106

Dependencies

  • This PR does not depend on other PR's

Test coverage

  • The changes in this PR do not require tests

Documentation

  • This PR does not require updating any documentation

also, changing the test message file
@IdanZimi
Copy link
Collaborator

IdanZimi commented Jun 7, 2023

Do you use the message fixture somewhere else beside the message tests? @MaayanMashhadi

@MaayanMashhadi
Copy link
Collaborator Author

Do you use the message fixture somewhere else beside the message tests? @MaayanMashhadi

I don't think so. As I see, the message fixture is only used in the message tests.

@SchSeba
Copy link

SchSeba commented Jun 8, 2023

I think we don't need to move something that is not used by any other test in the project

@amitCohen2
Copy link
Collaborator

I think its good convention to do it like that.
But also not necessary if it will not merge for this current demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message fixture to conftest Rename fixture saved_message to message
4 participants