Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Business page #126

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Business page #126

merged 4 commits into from
Jun 7, 2023

Conversation

TalReinfeld
Copy link
Contributor

@TalReinfeld TalReinfeld commented May 25, 2023

Creating a professional business page skeleton

This PR is depends on PR #127

Solve issue #89

image

@guybeckenstein
Copy link
Contributor

it failed in flake8 and pytest please fix it

Copy link
Contributor

@OfirBachar OfirBachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a lot of commit. please squash

@TalReinfeld TalReinfeld marked this pull request as ready for review June 5, 2023 17:34
Copy link
Contributor

@guybeckenstein guybeckenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
A lot of commits but this looks OK

Signed-off-by: TalReinfeld <[email protected]>
Connect between the professional component to its business page,
pressing the component will lead to its own business page.

Signed-off-by: TalReinfeld <[email protected]>
Signed-off-by: TalReinfeld <[email protected]>
Copy link
Contributor

@idosinger98 idosinger98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@idoyek idoyek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@OfirBachar OfirBachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guybeckenstein guybeckenstein requested a review from Yarboa June 6, 2023 20:52
@guybeckenstein guybeckenstein added the CoreReview-Ready Ready for mentor review label Jun 6, 2023
Copy link
Contributor

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yarboa Yarboa merged commit f548be7 into redhat-beyond:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CoreReview-Ready Ready for mentor review dependent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants