User Management backend - Base - Project restructure #36
Conversation
DoRTaL94
changed the title
- Renamed test folder to tests. - Renamed flask_init file to app and updated its name inside setup.sh. - Moved static and templates folders to edison folder.
- Changed network definition to private. - Added a dhcp bug fix.
Added init file to edison folder to make it a module.
| config.vm.box = "ubuntu/bionic64" | ||
| config.vm.provision :shell, path: "setup.sh" | ||
| config.vm.network :forwarded_port, guest: FLASK_PORT, host: FLASK_PORT | ||
| config.vm.network :forwarded_port, guest: POSTGRESQL_PORT, host: POSTGRESQL_PORT | ||
| config.vm.network "private_network", type: "dhcp" |
There was a problem hiding this comment.
you forgot to mention this change in your PR description
There was a problem hiding this comment.
well, they way you describe it there, tells people what you did - which should generally be obvious from the code, but not why you did it which is the one thing that code can never tell you on its own...
There was a problem hiding this comment.
Oh okay I didn't think about it, thank you. I'll rewrite it.
There was a problem hiding this comment.
@ifireball I referenced your comment in our discussion in the old PR.
There was a problem hiding this comment.
We'll personally I prefer to write a short summary of what I want people to know, instead of sending then to look for it in a discussion thread, but that is not a reason to block a PR.
edison/app.py
Outdated
| from flask import render_template | ||
|
|
||
|
|
||
| # API description in swagger - https://app.swaggerhub.com/apis/DoRTaL94/UserManagment/1.0.0 |
There was a problem hiding this comment.
is this comment relevant to this PR?
There was a problem hiding this comment.
No, it would probably be relevent when we will actually add the app routes.
I'll remove it.
Changed the linked issue to a more relevant one
fixes #27.
You can read about the reason behind this here.
@ahinoamta @RoniRush