User Management backend - Base - DB migrations #39
Conversation
- Renamed test folder to tests. - Renamed flask_init file to app and updated its name inside setup.sh. - Moved static and templates folders to edison folder.
- Changed network definition to private. - Added a dhcp bug fix.
Added init file to edison folder to make it a module.
Added config file so the app will auto configured once the flask app starts.
Added config file so the app will auto configured once the flask app starts.
Added triggers to Vagrantfile for up and destroy commands. After vagrant up is executed an attempt to restore db data accures. Before vagrant destroy is executed a save to db data accures.
Added Flask-Migrate extension for database migrations support. The content inside edison/migrations folder is auto-created by the extension.
|
Unfortunately GitHub makes it close to impossible to properly review PRs that depend on other PRs because it shows all the changes mixed together instead of letting you see only the changes in the relevant PR. So we'll need to merge the first PR before we can review the ones that depend on it (This is why I don't personally consider GitHub to be a serious code review platform). |
Changed the linked issue to a more relevant one
User Management backend - Base - Project restructure
2. replace comments with docstring
few changes in the docstring
change inspect.isclass(Config) to issubclass(obj, Config)
fixed the wrong checking - if a class is subclass of config
User Management backend - Base - Config file
…formatting and not contating
adding show policies
User Management backend - Base - DB support
There was a problem hiding this comment.
I'm not sure what is going on with this PR. It shows all the files as being new, even though they already exist in the repo (such as edison/init.py and edison/app.py). I can't see what changes were made if any and this looks like it would overwrite changes that were already made.
For example, in PR #38 you added import edison.models, but I don't see that in this code.
Probably you will need to rebase this PR with the repo and resubmit it
This is especially weird because it shows that there are no conflicts.
…of show condition and remove conditions. instead of creating form elemet from zero until count condition -1, createting the element from 1 until count condition and remove from one until the count condition
turn over a variable form global (count condition variable) to private
Added Flask-Migrate extension for database migrations support. The content inside edison/migrations folder is auto-created by the extension.
…to db-migrations # Conflicts: # requirements.txt
|
I'll open new PR, so the 'files changed' will be updated |
fixes #27.
This PR depends on PR #38.
Added Flask-Migrate extension for database migrations support.
The content inside edison/migrations folder is auto-created by the extension.
@ahinoamta @RoniRush