User Management backend - Base - JWT support #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed test folder to tests. - Renamed flask_init file to app and updated its name inside setup.sh. - Moved static and templates folders to edison folder.
- Changed network definition to private. - Added a dhcp bug fix.
Added init file to edison folder to make it a module.
Added config file so the app will auto configured once the flask app starts.
Added config file so the app will auto configured once the flask app starts.
Added triggers to Vagrantfile for up and destroy commands. After vagrant up is executed an attempt to restore db data accures. Before vagrant destroy is executed a save to db data accures.
- Added a callback that checks if JWT is blacklisted. Token should be inside the token_blacklist table if it is used for logout. - Added jwt configurations inside config file.
|
Unfortunately GitHub makes it close to impossible to properly review PRs that depend on other PRs because it shows all the changes mixed together instead of letting you see only the changes in the relevant PR. So we'll need to merge the first PR before we can review the ones that depend on it (This is why I don't personally consider GitHub to be a serious code review platform). |
Changed the linked issue to a more relevant one
|
THis PR should probably be rebased against the files in the repo and resubmitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #27.
This PR depends on PR #38.
Token should be inside the token_blacklist table if it is used for logout.
@ahinoamta @RoniRush