Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Management backend - Base - DB Models #47

Merged
merged 1 commit into from
May 31, 2020

Conversation

ahinoamta
Copy link
Collaborator

Added DB models- Token model, and extended User model

@DoRTaL94 @RoniRush

Copy link
Collaborator

@simzacks simzacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small comment about the .gitignore, it looks ready to go

@@ -16,3 +16,6 @@ _pycache_/

# Python
*.pyc
*.orig
*.pyc.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this be handled by the *.pyc above?
I made this comment already in PR #46 so it looks like these have to be merged in order.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, becasue the files look like this:
conftest.cpython-36-pytest-5.4.2.pyc.1764

When I try to remove '.pyc.', all the files in the pattern above were unstaged in Git.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be glad that this PR will be merged before #46 😃

Copy link

@Omeramsc Omeramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahinoamta ahinoamta requested a review from simzacks May 25, 2020 21:19
@DoRTaL94 DoRTaL94 merged commit 68a5e99 into redhat-beyond:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants