login-signin - Added fixes according to review #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoRTaL94
reviewed
Jun 1, 2020
Asaf-Federman
force-pushed
the
login-signin
branch
from
3763818 to
76a1b2d
Compare
Omeramsc
reviewed
Jun 14, 2020
| @@ -0,0 +1,106 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
It may be better to extend the existing 'layout.html' instead of creating a completely different one.
There was a problem hiding this comment.
Ill look into that when I have the time, kinda busy studying for exams at the moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11
Cloned previous PR #23 due to inactivity
Decoupled the css from the login template
Fixed inconsistency with get-element-id
Fixed file structure according to the existing one