Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Add Unit Tests and Coverage #53

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ahinoamta
Copy link
Collaborator

Runs pytest including coverage in the CI.
Uses pytest and pytest-cov.
Added a dummy test only for checking.

@ahinoamta ahinoamta self-assigned this May 31, 2020
@ahinoamta ahinoamta requested a review from simzacks May 31, 2020 20:21
Copy link
Collaborator

@DoRTaL94 DoRTaL94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments.
LGTM.

tests/dummy_test.py Outdated Show resolved Hide resolved
.github/workflows/edisonCI.yml Show resolved Hide resolved
@igoihman
Copy link
Contributor

igoihman commented Jun 4, 2020

please resolve conflicts

@@ -1,3 +1,5 @@
Flask==1.1.1
flask-sqlalchemy==2.4.1
psycopg2-binary==2.8.5
pytest==5.2.0
pytest-cov==2.9.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to separate the testing libraries to a different requirements file, say requirements-test.txt, Inside the tests folder, since they're not used in the app itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants