Address comments from Tom

- insert blank lines between tasks - make default to apply the fixes
redhat-cop · Jul 5, 2022 · c83b5fe · c83b5fe
1 parent e891a9e
commit c83b5fe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/roles/aap_setup_install/defaults/main.yml b/roles/aap_setup_install/defaults/main.yml
@@ -63,7 +63,7 @@ aap_setup_inst_extra_vars: {}
 aap_setup_inst_force: false
 
 # list of fixes to apply before starting the actual installation,
-# empty by default, possible values are listed below
-aap_setup_inst_fixes: []
-# - aap_4555  # setup.log is only saved on first call as non-root
+# review before bumping up the default AAP version
+aap_setup_inst_fixes:
+  - aap_4555  # setup.log is only saved on first call as non-root (2.2.0)
 ...
diff --git a/roles/aap_setup_install/tasks/fixes/aap_4555.yml b/roles/aap_setup_install/tasks/fixes/aap_4555.yml
@@ -6,6 +6,7 @@
   ansible.builtin.stat:
     path: "{{ aap_setup_inst_setup_dir }}/setup.log"
   register: __aap_setup_inst_log
+
 - name: AAP_4555 | create a backup of setup.log if it exists
   ansible.builtin.copy:
     src: /dev/null
@@ -14,6 +15,7 @@
     remote_src: true
     mode: 0664
   when: __aap_setup_inst_log.stat.exists
+
 - name: AAP_4555 | make sure setup.log doesn't exist
   ansible.builtin.file:
     path: "{{ aap_setup_inst_setup_dir }}/setup.log"