Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken example #192

Closed
wants to merge 1 commit into from
Closed

fix broken example #192

wants to merge 1 commit into from

Conversation

jon4hz
Copy link
Contributor

@jon4hz jon4hz commented Sep 5, 2023

This PR fixes a broken example in the aap_setup_install README.

@jon4hz
Copy link
Contributor Author

jon4hz commented Sep 5, 2023

Also I noticed that the ansible_become here overrides the become: false in the role automation_platform_installer.config_dynamic L58 which can lead to some issues. For example if you use an ee to execute that role, the task will most likely fail due to the missing sudo package inside the ee.

@sean-m-sullivan
Copy link
Collaborator

Not sure what we are trying to fix here, these are set to be list items, not dict items, and the template is working around lists,

could you post what happened that led to an error for this fix?

This has worked for me in the past

aap_setup_prep_inv_nodes:
  database:
    - 'hub.laptop'
  automationhub:
    - 'hub.laptop'

@jon4hz
Copy link
Contributor Author

jon4hz commented Sep 7, 2023

Actually, I'm not sure about that anymore either. When I started working with the aap_setup_prepare role, I got a weird template error when the inv_nodes were a list, but I guess the error was caused by something else, although I was pretty sure that changing the list to dict items solved the problem.

I tested my setup again with the nodes provided as a list and now it works, weird. Anyway... sorry for the confusion.

@jon4hz jon4hz closed this Sep 7, 2023
@sean-m-sullivan
Copy link
Collaborator

No worries, my worry was more if you had more then one node, the dict option would likely not work, but if you find that error again let us know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants