Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators-installer - add support for common labels set from global #367

Merged
merged 2 commits into from
Nov 3, 2023
Merged

operators-installer - add support for common labels set from global #367

merged 2 commits into from
Nov 3, 2023

Conversation

itewk
Copy link
Contributor

@itewk itewk commented Oct 31, 2023

What is this PR About?

adding ability for the operators-installer to pull commonLabels from the helm global values (https://helm.sh/docs/chart_template_guide/subcharts_and_globals/)

How do we test this?

updated one of the tests for this

cc: @redhat-cop/day-in-the-life

@itewk itewk marked this pull request as ready for review October 31, 2023 21:05
@itewk
Copy link
Contributor Author

itewk commented Nov 2, 2023

@eformat can you review and merge this after #368 ?

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041 sabre1041 merged commit 46b1127 into redhat-cop:master Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants