Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added extraConfig section #376

Merged
merged 1 commit into from
Nov 9, 2023
Merged

added extraConfig section #376

merged 1 commit into from
Nov 9, 2023

Conversation

ckavili
Copy link
Contributor

@ckavili ckavili commented Nov 9, 2023

What is this PR About?

Added extraConfig section to support this so that configs like pointing to a custom DB etc can be done.

How do we test this?

Provide commands/steps to test this PR.

helm template .

cc: @redhat-cop/day-in-the-life

@ckavili ckavili requested a review from eformat November 9, 2023 13:05
Copy link
Contributor

@springdo springdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@springdo
Copy link
Contributor

springdo commented Nov 9, 2023

Missing emojis on the commit and issue though @ckavili :/
I'll try to add them to the merge commit though

@springdo springdo merged commit dff403c into redhat-cop:master Nov 9, 2023
3 checks passed
@ckavili
Copy link
Contributor Author

ckavili commented Nov 9, 2023

nooooo!!!! revert revert!! damn..I lost my habit of using gitmoji shortcut! too much time I've been spending on customer environments ahha

@ckavili
Copy link
Contributor Author

ckavili commented Nov 9, 2023

thanks for adding emojis there @springdo , really appreciated!!

@ckavili ckavili deleted the aap branch November 9, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants