Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart for upstream Keycloak Operator and instance. #57

Closed
wants to merge 32 commits into from

Conversation

jtudelag
Copy link
Contributor

No description provided.

@jtudelag
Copy link
Contributor Author

So it is currently failing due to the maintainers....not sure how to digest that.

@jtudelag
Copy link
Contributor Author

jtudelag commented Jun 23, 2020

Issue upstream, helm/chart-testing#192. My question is. How the hell ct compares repo maintainers? I am assuming it talks to github API...

@jtudelag
Copy link
Contributor Author

Leaving aside that I'm starting to hate ct ,we should think the right approach here.

@jtudelag
Copy link
Contributor Author

Addressing also rht-labs/ubiquitous-journey#5

@jtudelag
Copy link
Contributor Author

Also rht-labs/ubiquitous-journey#128

@eformat
Copy link
Contributor

eformat commented Jul 21, 2020

Leaving aside that I'm starting to hate ct ,we should think the right approach here.

Hi @jtudelag - OK .. the ct lint fails .. cause your maintainer handle has to match user id in github, missing 'g', change Chart.yaml to:

  • name: jtudelag

and ct lint will work

ct lint --debug --target-branch=jtudelag-keycloak-operator --charts=charts/keycloak-operator

@jtudelag
Copy link
Contributor Author

Leaving aside that I'm starting to hate ct ,we should think the right approach here.

Hi @jtudelag - OK .. the ct lint fails .. cause your maintainer handle has to match user id in github, missing 'g', change Chart.yaml to:

* name: jtudelag

and ct lint will work

ct lint --debug --target-branch=jtudelag-keycloak-operator --charts=charts/keycloak-operator

Pff....thanks @eformat for the hint! I was going insane with ct, still dont like it ;).

Adding new lines

Fix typo in maintaner name...
@jtudelag jtudelag force-pushed the keycloak-operator branch from 04a1b8a to 07a4797 Compare July 28, 2020 08:26
@jtudelag
Copy link
Contributor Author

Squashed commits, fixed the maintainer name typo...

jayfray12 and others added 19 commits July 29, 2020 10:16
Updated Chart version
Change the resource.limits.memory to the correct value
* 🐭 FIX - New org names etc 🏰

* 🐭 FIX - bump to keep ct tool happy 🏰
🧪 ADD - Collection of charts used in UJ as docs for others to see 🏂
…ename-1

🐪 switch to agent naming 🐪
Copy link
Contributor

@garethahealy garethahealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can a conftest be added before merging please:

@jtudelag jtudelag closed this Oct 20, 2020
@jtudelag jtudelag deleted the keycloak-operator branch October 20, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants