Skip to content
This repository has been archived by the owner on Oct 3, 2019. It is now read-only.

Update.version.runtime controller #144

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

corinnekrych
Copy link
Contributor

This PR is about:

  • updating Status with subresource so that Update only updates status and not the whole component
  • update runtime-controller to v0.2.0 (i notice it makes update subresource more stable)
  • use instance label to select dc, bc

"pkg/apis",
"pkg/apis/devconsole/v1alpha1",
]
source = "github.com/corinnekrych/devconsole-api"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably point to redhat-developer/devconsole-api instead of corinnekrych/devconsole-api?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. this is temporary. will remove it once redhat-developer/devconsole-api#23 is merged

@corinnekrych corinnekrych force-pushed the update.version.runtime-controller branch from 03e8d49 to 88eb917 Compare April 26, 2019 09:21
Copy link
Collaborator

@tinakurian tinakurian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tinakurian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@corinnekrych
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Collaborator

@corinnekrych: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/test b8adfbc link /test test
ci/prow/lint b8adfbc link /test lint
ci/prow/e2e b8adfbc link /test e2e
ci/prow/e2e-ci b8adfbc link /test e2e-ci
ci/prow/e2e-olm-ci b8adfbc link /test e2e-olm-ci
ci/prow/images b8adfbc link /test images
ci/prow/upgrade-ci b8adfbc link /test upgrade-ci

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants