-
Notifications
You must be signed in to change notification settings - Fork 28
Update.version.runtime controller #144
base: master
Are you sure you want to change the base?
Update.version.runtime controller #144
Conversation
"pkg/apis", | ||
"pkg/apis/devconsole/v1alpha1", | ||
] | ||
source = "github.com/corinnekrych/devconsole-api" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably point to redhat-developer/devconsole-api instead of corinnekrych/devconsole-api?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. this is temporary. will remove it once redhat-developer/devconsole-api#23 is merged
03e8d49
to
88eb917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tinakurian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@corinnekrych: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR is about: